Manchester | ITP-May-2025 | Chukwuemeke Ajuebor | Module-Structuring-and-Testing-Data | Sprint-1 #603
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AjueborChukwuemeke
added
the
Needs Review
AjueborChukwuemeke
changed the title
LonMcGregor
added
Review in progress
LonMcGregor
reviewed
Jul 4, 2025
| @@ -12,11 +12,14 @@ console.log(`The percentage change is ${percentageChange}`); | |||
| // Read the code and then answer the questions below | |||
|
|
|||
| // a) How many function calls are there in this file? Write down all the lines where a function call is made | |||
|
|
|||
| // There are three; Ln4, Ln5, Ln10. | |||
There was a problem hiding this comment.
There are 3 lines with function calls on them. How many function calls are there in total?
|
|
||
| // b) How many function calls are there? | ||
| // There is no function call. | ||
|
|
There was a problem hiding this comment.
What are you using to view the result variable? Are you sure there are 0 function calls?
|
|
||
| // e) What do you think the variable result represents? Can you think of a better name for this variable? | ||
| //It represents the movie duration in the format; HH:MM:SS. A good name would be "movieduration" | ||
|
|
There was a problem hiding this comment.
Do you think that "movieduration" offers a clear enough difference to the earlier "movieLength" variable?
|
|
||
| // f) Try experimenting with different values of movieLength. Will this code work for all values of movieLength? Explain your answer | ||
| // Yes it will as long as the minimum movielength is 1 sec. The divided operand will always be returned if the dividing operand can go into it. |
There was a problem hiding this comment.
Can you think of any cases where the output might not look correct?
LonMcGregor
added
👀 Review Requirements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.